Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5 and @yair-starkware)

crates/starknet_http_server/src/errors.rs line 33 at r2 (raw file):

    let general_rpc_error = match err {
        GatewayClientError::ClientError(e) => {
            error!("Got a gateway client: {}", e);

Encountered a ClientError

Code quote:

Got a gateway client

crates/starknet_http_server/src/errors.rs line 43 at r2 (raw file):

            source,
            p2p_message_metadata: _,
        }) => {

Please add a todo to into_rpc() on the entirety of GatewayError, not just the source member.

Code quote:

        GatewayClientError::GatewayError(GatewayError::GatewaySpecError {
            source,
            p2p_message_metadata: _,
        }) => {

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @Itay-Tsabary-Starkware)

crates/starknet_http_server/src/errors.rs line 33 at r2 (raw file):

Done.

crates/starknet_http_server/src/errors.rs line 43 at r2 (raw file):

Done.

Reviewed 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5 and @yair-starkware)

crates/starknet_http_server/src/errors.rs line 44 at r4 (raw file):

            p2p_message_metadata: _,
        }) => {
            // TODO(Itay): Add the p2p_message_metadata to the error response.

1. I go by Tsabary :-)
2. The todo is for you :-)

Non-blocking, but please change 👍

Code quote:

// TODO(Itay): Add the p2p_message_metadata to the error response.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @yair-starkware)

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)